Skip to content

update pr testing workflow with stronger checks - #49434

Merged
johnsonaj merged 2 commits into
mainfrom
td-teamcity_pattern_parsing
Aug 17, 2026
Merged

update pr testing workflow with stronger checks#49434
johnsonaj merged 2 commits into
mainfrom
td-teamcity_pattern_parsing

Conversation

@johnsonaj

@johnsonaj johnsonaj commented Aug 12, 2026

Copy link
Copy Markdown
Member

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

  • Stronger regex checks for valid characters when passing test patterns
  • remove eval when running tctest
  • Append _ split character to test discovery so test cases are more specific

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. github_actions Pull requests that update Github_actions code size/S Managed by automation to categorize the size of a PR. labels Aug 12, 2026
@johnsonaj
johnsonaj marked this pull request as ready for review August 12, 2026 21:52
jar-b
jar-b approved these changes Aug 13, 2026
View reviewed changes

@jar-b jar-b left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@johnsonaj
johnsonaj merged commit 1d2fa7c into main Aug 17, 2026
30 checks passed
@johnsonaj
johnsonaj deleted the td-teamcity_pattern_parsing branch August 17, 2026 17:21
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions Bot added this to the v6.61.0 milestone Aug 17, 2026
@github-actions github-actions Bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 19, 2026
@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

This functionality has been released in v6.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jar-b jar-b jar-b approved these changes
@breathingdust breathingdust Awaiting requested review from breathingdust breathingdust is a code owner
@justinretzolk justinretzolk Awaiting requested review from justinretzolk justinretzolk is a code owner

Assignees

No one assigned

Labels

github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/S Managed by automation to categorize the size of a PR.

Projects

None yet

Milestone

v6.61.0

Development

Successfully merging this pull request may close these issues.

2 participants

@johnsonaj @jar-b